fixed:issue->#1968 Import from nYNAB fails with unknown error #2191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
1 task
|
Thanks! Would you be OK adding the same logic for the other category/payee matchers in the same file? Might as well fix it everywhere if we've gone so far. |
joel-jeremy
requested changes
Jan 8, 2024
trafico-bot
bot
added
⚠️ Changes requested
trafico-bot
bot
added
🔍 Ready for Review
and removed
⚠️ Changes requested
Marethyu1
force-pushed
the
fix-1968
branch
3 times, most recently
from
4b47f15 to
aad2bd6
Compare
|
👋 I have extracted the check and applied it to all the string literals in the file. Seems like it might be out of the scope for what we initially set out to change. Let me know what y'all think, can always drop the last couple of commits. Thanks. |
Marethyu1
force-pushed
the
fix-1968
branch
2 times, most recently
from
010f4d0 to
2ffbbfa
Compare
joel-jeremy
reviewed
Jan 12, 2024
and reuse when checking starting balance/s on ynab4 import
when importing from ynab5 to make the check strategy consistent when importing from ynab5
to 'simplify' usage
Co-authored-by: Joel Jeremy Marquez <[email protected]>
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
…error (actualbudget#2191) * Allow case insensitive ynab5 import for special 'starting balance' payee * set upcoming release number to related github issue * extract string comparison into separate function and reuse when checking starting balance/s on ynab4 import * make all category group checks case insensitive when importing from ynab5 to make the check strategy consistent when importing from ynab5 * extract findById into sreusable function to 'simplify' usage * Add null check Co-authored-by: Joel Jeremy Marquez <[email protected]> --------- Co-authored-by: Joel Jeremy Marquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow case insensitive ynab5 import for special 'starting balance' payee
Fixes issue for attached budget in this #1968 (comment)
by allow case insensitive search for starting balance.
Should address #1968 as described in this comment #1968 (comment)